Feature read correct favicon from feed rss #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigihenrick
force-pushed
the
feature/read-favicon-from-feed-rss
branch
from
5ff1942 to
8b94299
Compare
|
Hi, thanks for taking the time to address this issue. It was an intentional decision to use the link to fetch the fav icon rather than the feed icon. We noticed that not all feed icons are touch-friendly icons that are easy to identify. Since favicons are something that are well optimised for this, we used those. So, let me look into this further with the FreshRSS links. Is it possible to share the OPML with me over email hello@sasikanth.dev, so that I can try out my changes? |
|
Sure, just sent you my feeds, thanks for quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this relates to issue #785.
I have done a further investigation and discovered that in current version of the app the icon loaded is retrieved using the
<link>property from the feed, and not the<image><url>for RSS or<icon><logo>for ATOM.So I have replaced this logic, and now it gets the configured icon for the feed, and when is not available, uses the previous logic, so it gets from
feed.homepageLink.I am not a mobile developer, so all insights are welcome.
And I have already mentioned, but thanks again, amazing app!
Evidence:
I am using same OPML file that on issue, I can share privately with project maintainers, as I am self hosting my feeds.