Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Changing String Column Name Clears Max Length Property #173

Closed
ab-tools opened this issue Apr 13, 2020 · 3 comments
Closed

Changing String Column Name Clears Max Length Property #173

ab-tools opened this issue Apr 13, 2020 · 3 comments
Labels
bug Confirmed bug released Issue is resolved in a current release
Milestone

Comments

@ab-tools
Copy link

When you have a string column e. g. with a max length of 255 set and you change the name of this column it clears the max length property.

Is there a technical requirement to do this?

I mean it's nothing super problematic as you can just fill in the max length property again, but it's a bit dangerous as you need to remember the value first and don't forget to add it back in (so a potential risk of unnecessary mistakes).

@msawczyn
Copy link
Owner

No, that shouldn't happen. Thanks, I'll fix that. Are you changing the column name or the property name?

@msawczyn msawczyn added the bug Confirmed bug label Apr 13, 2020
@ab-tools
Copy link
Author

Thanks for your quick reply, Michael!

I was changing the property "Name".
When I change the "Column Name" property it does not clear the "Max Length" field, just with the property "Name".

@msawczyn msawczyn added this to the 2.0.1 milestone Apr 13, 2020
@msawczyn msawczyn added investigating Looking into this bug Confirmed bug pending release Issue is resolved in the current codebase, will be published with the next release released Issue is resolved in a current release and removed bug Confirmed bug investigating Looking into this pending release Issue is resolved in the current codebase, will be published with the next release labels Apr 13, 2020
@msawczyn
Copy link
Owner

Nice catch. That was part of a feature that never got documented, no one ever used, and wasn't implemented 100%, so now it's gone. As is the problem.

@msawczyn msawczyn added pending release Issue is resolved in the current codebase, will be published with the next release and removed released Issue is resolved in a current release labels Apr 16, 2020
msawczyn added a commit that referenced this issue Apr 16, 2020
@msawczyn msawczyn added released Issue is resolved in a current release and removed pending release Issue is resolved in the current codebase, will be published with the next release labels Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug released Issue is resolved in a current release
Projects
None yet
Development

No branches or pull requests

2 participants