Review comment update

- refactor to avoid lookup every time and to ensure consistency in case cfg changes
mscdex · Jul 22, 2024 · 0d8223a · 0d8223a
1 parent 1bd608d
commit 0d8223a
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -273,12 +273,14 @@ class Client extends EventEmitter {
     let hostVerifier;
     if (typeof cfg.hostVerifier === 'function') {
       const hashCb = cfg.hostVerifier;
-      hostVerifier = (key, verify) => {
+      let hashAlgo;
       if (HASHES.indexOf(cfg.hostHash) !== -1) {
-          // Default to old behavior of hashing on user's behalf
-          const hasher = createHash(cfg.hostHash).update(key);
-          key = hasher.digest('hex');
-        }
+        // Default to old behavior of hashing on user's behalf
+        hashAlgo = cfg.hostHash;
+      }
+      hostVerifier = (key, verify) => {
+        if (hashAlgo)
+          key = createHash(hashAlgo).update(key).digest('hex');
         const ret = hashCb(key, verify);
         if (ret !== undefined)
           verify(ret);