Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set node-gyp as an optional peer dependency #1379

Closed
wants to merge 1 commit into from
Closed

set node-gyp as an optional peer dependency #1379

wants to merge 1 commit into from

Conversation

quisido
Copy link

@quisido quisido commented Mar 16, 2024

Resolves #1378

Sorry if this requires npm install to update package-lock.json. I made this edit from the GitHub UI, so I was unable to run the CLI.

@quisido
Copy link
Author

quisido commented Apr 10, 2024

@mscdex Can this one get reviewed? 😅 It just makes the optional peer dependency as optional.

@tranhoangdong

This comment was marked as off-topic.

Sign in to view
@quisido quisido closed this by deleting the head repository Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify node-gyp as a dependency.
2 participants
@quisido @tranhoangdong