Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix request start position for chunks larger than 31952 bytes #1171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeffrson
Copy link

This PR fixes the later issue in #1162

@mscdex
Copy link
Owner

mscdex commented Apr 24, 2022

This needs a test

@jeffrson
Copy link
Author

Done. Test should fail with current master.

@jeffrson
Copy link
Author

jeffrson commented Apr 29, 2022

@mscdex Have you had a look at this rather simple PR? It's a pity it isn't included in the new release, since the fix is rather important for chunks larger than 31952 bytes.

@mscdex
Copy link
Owner

mscdex commented Apr 29, 2022

It hasn't been merged yet because I haven't had time to make sure it's the right change in the right place.

@jeffrson
Copy link
Author

jeffrson commented May 1, 2022

Without a doubt I understand that time is short - I just wasn't sure if I had to mention you again. Sorry.

Nevertheless I hope you'll soon find time to confirm the fix or have a better. At the moment I have to reference a personal git repo for a fixed version, which is not ideal.

From the test I adjusted you will see, that it will fail for the current "official" version. I think it's not too uncommon to use buffer sizes slightly larger than 31952, which should always cause an error if the returned position is to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants