Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auth-agent (server) #781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for auth-agent (server) #781

wants to merge 1 commit into from

Conversation

131
Copy link
Contributor

@131 131 commented Apr 19, 2019

The auth-agent-req@openssh.com channel is not implemented on the server side.

The server need to acknowledge the request by opening a channel (see openssh source code )

Again, this is an amazing project and i'm very excited being able to help, even if it's just a little.

@131
Copy link
Contributor Author

131 commented Apr 20, 2019

Ok, i ended up doing it \o/

This PR relies on a requirement PR in ssh2-stream

@131 131 changed the title Need help : add support for auth-agent (server) Add support for auth-agent (server) Apr 20, 2019
@131
Copy link
Contributor Author

131 commented Jul 2, 2019

All good since mscdex/ssh2-streams#132 has landed (just rebased it)

lib/server.js Outdated Show resolved Hide resolved
lib/server.js Outdated Show resolved Hide resolved
lib/server.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@131
Copy link
Contributor Author

131 commented Jul 8, 2019

I've updated the PR with requested changes

lib/server.js Outdated Show resolved Hide resolved
@mscdex
Copy link
Owner

mscdex commented Jul 8, 2019

Also can you add a test for this? I understand it will (currently) require the master ssh2-streams branch and that's ok.

@131
Copy link
Contributor Author

131 commented Jul 8, 2019

I've updated the PR again, (with the style change - sorry for that). I'm looking into the "test" part now

@131
Copy link
Contributor Author

131 commented Jul 8, 2019

So, testing the agent stream requires me to spawn a "real" ssh-agent. Is that okay with you ?

@mscdex
Copy link
Owner

mscdex commented Sep 14, 2019

Do we really need ssh-agent to be running? I think just spinning up a unix socket server locally may be enough? Also we might need to skip this test on Windows, unless there is some way we can detect we're in WSL in which case (i'm assuming) unix sockets are available?

@131
Copy link
Contributor Author

131 commented Sep 16, 2019

I've updated the PR with ssh-streams2 bump (as this is needed) so the tests can pass.

I've spend some time on it, but i cannot find a way to test openssh_authAgent without running a proper agent server.

If spawning an external server bother you, i've wrote a pure js ssh-agent server, but that's another story. Also, this PR is working fine under WSL (as i'm working only on this stack)

test/test-client-server.js Outdated Show resolved Hide resolved
@131
Copy link
Contributor Author

131 commented Jun 24, 2021

I'll rebase that for 1@

@131
Copy link
Contributor Author

131 commented Jun 25, 2021

Hi @mscdex , is there anything more you want on this one ?

@131 131 force-pushed the master branch 2 times, most recently from 1efa86c to 40fa58f Compare June 27, 2021 22:13
@alireza-ebrahimi
Copy link

alireza-ebrahimi commented Aug 26, 2024

Hi @mscdex, is there any other problem with this pull request? i'm implementing a ssh proxy and this feature is required to implement public key login on destination. i also tested changes on my local env and its working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants