Use authMethodsLeft in the sample servers #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 4252, which covers ssh authentication, allows clients to respond to request the auth method 'none', to which the server should respond with a list of allowed methods. In particular, WinSCP performs this check, and if the server responds with an empty list, it terminates the session. (Most other clients just try various methods without checking.) So, it'll be good to handle this case in the sample server implementations as a hint to implementors about this part of the protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 4252, which covers ssh authentication, allows clients to respond
to request the auth method 'none', to which the server should respond
with a list of allowed methods. In particular, WinSCP performs this
check, and if the server responds with an empty list, it terminates
the session. (Most other clients just try various methods without
checking.)
So, it'll be good to handle this case in the sample server
implementations as a hint to implementors about this part of the
protocol.