Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import changes from WIP #37

Merged
merged 6 commits into from
May 17, 2024
Merged

Import changes from WIP #37

merged 6 commits into from
May 17, 2024

Conversation

mseri
Copy link
Owner

@mseri mseri commented May 17, 2024

Addresses #25

mseri added 4 commits May 17, 2024 15:36
@mseri
Update CONTRIBUTING file
05f9061 
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Birkhoff.lean: import changes to from wip branch
86cb0de 
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Birkhoff.lean: slighlty polish comments and proofs
b95eef3 
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Birkhoff.lean: avoid deprecation warning
28302a2 
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Copy link
Owner Author

mseri commented May 17, 2024

@oliver-butterley do you think I should be more aggressive in picking the changes?

@mseri
Birkhoff.lean: keep the sketch of the proof for reference
3f03f86 
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
oliver-butterley
oliver-butterley approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@oliver-butterley oliver-butterley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is more to be trimmed out but I would leave it like this at the moment and when Marco is back in action we arrange everything properly. I hope we can do this when we meet in Pisa!

CONTRIBUTING.md Show resolved Hide resolved
@mseri @oliver-butterley
Update CONTRIBUTING.md
443d070 
Co-authored-by: Oliver Butterley <51876429+oliver-butterley@users.noreply.github.com>
@mseri mseri merged commit f736be0 into main May 17, 2024
1 check failed
@mseri mseri deleted the import-wip branch June 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-butterley oliver-butterley oliver-butterley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mseri @oliver-butterley