-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
House keeping: tidying everything #4
Conversation
oliver-butterley
commented
Feb 20, 2024
- Split lean code into separate files
- Streamline github action
- Add vscode nice settings
- Bump lean version and make required correction to one proof
- Etc
I suggest the "Squash and merge" commit method to reduce the main history. |
Nice! Thanks. As per the merge: Do we really care about having a such a concise history when your commits are already so explicative? I’d be actually inclined in merging with a merge commit |
I feel we are saying the same thing but with different words... Most importantly, I don't have a strong point of view on this, this is a minor preference I have. |
Yes I know the difference, I meant that I in general like to see the breakdown of the history :) I tend to use squash and merge only when the PR is messy |
I assume the license is apache to fit in with lean/mathlib one |
Yes, licence is there apache license, identical to mathlib. I don't want to ever think about legal things but I understand that such is useful to guarantee the code is a always free in the future. |
Yes, actually that makes good sense. |