Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let Encoder and Decoder accept named params as encode() and decode() do #224

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

gfx
Copy link
Member

@gfx gfx commented Mar 10, 2023

This is a major interface change even if the interfaces of Encoder and Decoder were not described in README.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 🎉

Comparison is base (c4d65d6) 98.38% compared to head (a7efd6b) 98.58%.

❗ Current head a7efd6b differs from pull request most recent head 842dc45. Consider uploading reports for the commit 842dc45 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   98.38%   98.58%   +0.20%     
==========================================
  Files          16       16              
  Lines         990      990              
  Branches      202      195       -7     
==========================================
+ Hits          974      976       +2     
+ Misses         16       14       -2     
Impacted Files Coverage Δ
src/Decoder.ts 99.19% <100.00%> (+<0.01%) ⬆️
src/Encoder.ts 98.14% <100.00%> (+<0.01%) ⬆️
src/decode.ts 100.00% <100.00%> (ø)
src/decodeAsync.ts 100.00% <100.00%> (+9.52%) ⬆️
src/encode.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gfx gfx merged commit 7ad7809 into main Mar 10, 2023
@gfx gfx deleted the gfx/decoder-and-encoder-take-object-params branch March 10, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants