fix RangeError in encoding BLOB #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
- Coverage 96.9% 96.9% -0.01%
=========================================
Files 15 15
Lines 905 904 -1
Branches 183 183
=========================================
- Hits 877 876 -1
Misses 28 28
Continue to review full report at Codecov.
|
sergeyzenchenko
approved these changes
Jun 12, 2019
| @@ -300,14 +301,11 @@ export class Encoder { | |||
| this.pos++; | |||
| } | |||
|
|
|||
| writeU8v(...values: Array<number>) { | |||
| writeU8a(values: ArrayLike<number>) { | |||
There was a problem hiding this comment.
YES, I was not spend too much time in Encoder, but i was going to mention to you ...reset params usage. This is not good for performance. TS maps it into loops and additional array allocation from passed arguments.
There was a problem hiding this comment.
Yeah, it is not just slow but causes RangeError for a large array. Too bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #65