Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect stack size even further #90

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

chrisnojima
Copy link
Contributor

Hi,

Sorry to touch this same area again! Turns out my previous fix wasn't enough for most use cases. In isolation reducing it by 4 was enough to pass tests but if your code is running on any kind of stack itself you'll run out of stack space. Looking at what some other projects do it seems pretty popular to just change this value to give yourself some headroom (like: https://github.com/feross/buffer/blob/master/index.js#L1023)

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          16       16           
  Lines         962      962           
  Branches      196      196           
=======================================
  Hits          946      946           
  Misses         16       16
Impacted Files Coverage Δ
src/utils/utf8.ts 96.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b306d...3112703. Read the comment docs.

@gfx
Copy link
Member

gfx commented Nov 1, 2019

I think the available stack size varies in browsers, but yes the current size is too big. Thanks for your efforts.

@gfx gfx merged commit 516cb45 into msgpack:master Nov 1, 2019
@gfx
Copy link
Member

gfx commented Nov 1, 2019

Released as v1.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants