Add type stubs. #404
Closed
Add type stubs. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 88.06% 87.94% -0.12%
==========================================
Files 5 5
Lines 846 846
==========================================
- Hits 745 744 -1
- Misses 101 102 +1
Continue to review full report at Codecov.
|
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
…a mypy run Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
|
I'm sorry, but I am not an expert of typing and I can not maintain it. I will drop Python 2 support completely in next major version (in 2021 or 2022). I will reconsider this after it. |
|
@methane no worries, I see that someone has created a stubs-only package recently: https://github.com/sbdchd/msgpack-types. So this is not an issue anymore, thus closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PEP 561 compatibility to
msgpack.I keep the type stubs from this PR for development with
msgpack. The idea is to make them available to everyone by adding them to the distribution. There are no changes to themsgpackcode itself, the stub is completely separated from the real code.If you are against adding type stubs, I'd still be grateful for a review that would improve the stub quality - maybe you have a good advice on how to deal with the remaining
Anytypes.