Compatibility mode #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing `compatibility_mode: true` to MessagePack.pack or `MessagePack::Packer.new` the encoder uses the old MessagePack spec and avoids the bin and str8 types.
When passing `compatibility_mode: true` to MessagePack.pack or `MessagePack::Packer.new` the encoder uses the old MessagePack spec and avoids the bin and str8 types.
These tests should probably be used for the MRI implementation too.
|
How about |
|
I must say I don't see any benefit in using the shorter form "compat" over "compatibility mode". I was thinking of something that describes it better, that explains what is it compatible with. I want to express "backwards compatible" and "don't use new features" and "raw not bin or str8". |
|
We don't have appropriate name for what it is compatible with... |
|
Merged to master. |
|
👍 |
|
That's great, thanks for the review and the cruby code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to
MessagePack.packandMessagePack::Packer.newthat makes the packer work in what the MessagePack specification calls "compatibility mode" – it disables the bin and str8 types.This should solve #67.
Please note that I know next to nothing about writing Ruby C extensions. Someone, perhaps @tagomoris, should look at that and give me hints to how to do it properly.
I'm not super happy about calling the option
:compatibility_mode, so if there are any other suggestions I would be happy to change it.