Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for custom activity fields #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for custom activity fields #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de88aaf
Address Edgecase where custom activity fields are written as Task/Eve…
rschmidtSFDC Oct 9, 2021
2011ca0
Special handling of Global layouts because there is no Global object
rschmidtSFDC Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/commands/shane/object/perms/align.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ export default class PermAlign extends SfdxCommand {
const fieldName = `${item.field.split('.')[1]}.field-meta.xml`;
if (objects.includes(objectName) && fs.readdirSync(`${objDir}/${objectName}/fields`).includes(fieldName)) {
return true;
} else if ((objectName == 'Task' || objectName == 'Event') && fs.readdirSync(`${objDir}/Activity/fields`).includes(fieldName)) {
return true;
}
this.ux.log(`${chalk.cyan(targetFilename)}: removing field perm for ${item.field}`);
return false;
Expand All @@ -106,6 +108,8 @@ export default class PermAlign extends SfdxCommand {
const objectName = item.layout.split('-')[0];
if (objects.includes(objectName) && layouts.includes(`${item.layout}.layout-meta.xml`)) {
return true;
} else if (objectName == 'Global' && layouts.includes(`${item.layout}.layout-meta.xml`)) {
return true;
}
this.ux.log(`${chalk.cyan(targetFilename)}: removing layout assignment for ${item.layout}`);
return false;
Expand Down