[BUG] localparams added as params in module instance

[markusdd]

Describe the bug
A clear and concise description of what the bug is.

Environment (please complete the following information):

• OS: macOS catalina
• VS Code version 1.45
• Extension version 1.0.6

Steps to reproduce
create a simple module using a localparam
instantiate this module using the instantiate module command

Expected behavior
localparams are not added to instantiation

Actual behavior
localparams are added to instantiation, which is syntactically and semantically wrong

[markusdd]

The problem is most likely here. Constants also incorporante localparams und specparams.

The fix would be to quickly parse the actual string that ctags gives and check if the definition actually starts with 'parameter'

[markusdd]

Parsing that out of ctags is currently tedious.
I ahve opened an upstream issue to provide a cleaner way of seperating defines, localparams, parameters and specparams:
universal-ctags/ctags#2537

[hirooih]

Note that Universal Ctags fixed the issue in Oct. 2020, universal-ctags/ctags#2537 (comment).

[Mightlaus]

Sorry, I still don't know how to correctly configure ctags to ignore localparam when instantiating.

I've tried adding --fields-Verilog=+{parameter} arguments, but it seems to result in opposite effect -- Only the parameter constants are being ignored, while all other localparam constants persist when instantiating.

This is my plugin setting:

This is the instantiation results:

Environment::
OS: Windows 10 22H2
Ctags: v6.0.0-x64
VScode: v1.84.2
Plugin: v1.13.0

[hirooih]

@Mightlaus

I added a new feature to Universal Ctags to fix this issue three years ago. I am disappointed to know that it has not been used.

Although I have little experience for typescript programming, I made a fix and sent a PR (#457).
As I wrote in the PR, the fix is not tested, because I don't have environment to test VS code extension.

I hope this helps this project.

[RickyTino]

Hi, I am quite sure this untested fix has caused #479 , which occurs on v1.13.1 but not seen on v1.13.0.
Until now ctags still recognizes all kind of params as 'constant' but not 'parameter’