Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linters and some errors #146

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fix linters and some errors #146

merged 2 commits into from
Apr 28, 2021

Conversation

kaz-on
Copy link
Contributor

@kaz-on kaz-on commented Apr 4, 2021

Hi.
This PR will fix following.

  • package.json
    • Fix description of xvlog arguments setting.
  • XvlogLinter.ts
    • Fix xvlog arguments setting requiring additional whitespace.
    • Fix error message not being detected correctly if it contains brackets [].
    • Add support for warning messages.
  • VerilatorLinter.ts
    • Fix file paths being treated as regular expressions.
  • LintManager.ts
    • Add linting for open documents on launch.
  • extension.ts
    • Fix Verilog: Rerun lint tool command not working.
  • ctags.ts, DefinitionProvider.ts, HoverProvider.ts
    • Fix errors reported in the Developer Tools that the variable is undefined.

@kaz-on
Copy link
Contributor Author

kaz-on commented Apr 6, 2021

I have made an additional fix for some cases where ctags symbols were not updated.
I will open the PR after merging of this PR, because the fix has a dependency with this PR.
Or is it better to modify this PR itself?

@mshr-h mshr-h merged commit 86fedc4 into mshr-h:master Apr 28, 2021
@mshr-h
Copy link
Owner

mshr-h commented Apr 28, 2021

LGTM. Thanks! 😄

I will open the PR after merging of this PR, because the fix has a dependency with this PR.
Sure.

@kaz-on kaz-on mentioned this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants