-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-request: Feature add linter slang #387
Conversation
Thanks! I'll check it maybe in the week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@retar-kamuy
The implementation is straightforward and easy to understand. So I'm okay to merge it. But there might be a need to discuss the arguments passed to the slang command.
@Raamakrishnan
Any comment is welcome.
Hi, @mshr-h san
I understand your thinking. How about the code below?
+ let args: string[] = [];
- args.push('--single-unit');
+ args.push(`-I ${docFolder}`);
+ args = args.concat(this.includePath.map((path: string) => `-I ${path}`));
+ args.push(this.arguments);
+ args.push(`"${docUri}"`);
- args.push('-Weverything', '--strict-driver-checking'); // Slang all warnings check options
``` |
@retar-kamuy |
Hi, @mshr-h san
Sorry I'm late.
Re-PR by your style and re-commit. Please check this commit.