Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support module definitions by looking for file name #470

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

AndrewNolte
Copy link
Contributor

@AndrewNolte AndrewNolte commented Mar 13, 2024

  • Looks for symbol.sv in the repo when searching on hover and definition
  • Package refs, modports follow their parent and search for that module/package/interface
  • switched a bunch of stuff to async/await
  • cleaned up logs

TODO (future work):

  • This might leave indexed files in longer than they should be
  • We should only be searching on module defs, not all symbols. It looks like we only find the kind of symbol defs, not any rhs
  • have the async tasks race and cancel the lagging one

@AndrewNolte
Copy link
Contributor Author

This PR should be good to go now @mshr-h

@mshr-h
Copy link
Owner

mshr-h commented Mar 23, 2024

Thanks for your hard work. And sorry for the late reply. Looks like your idea is good to me. I'll merge it.

@mshr-h mshr-h merged commit 487543b into mshr-h:main Mar 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants