Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters back into Module instantiation #496

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add parameters back into Module instantiation #496

merged 1 commit into from
Aug 26, 2024

Conversation

Raamakrishnan
Copy link
Contributor

Should fix #479
ModuleTags was filtering by constant while ModuleInstiation was filtering by parameter

@Raamakrishnan Raamakrishnan mentioned this pull request Aug 25, 2024
Closed
@mshr-h mshr-h merged commit 11dd164 into mshr-h:main Aug 26, 2024
5 checks passed
@mshr-h
Copy link
Owner

mshr-h commented Aug 26, 2024

Thanks!

@Raamakrishnan Raamakrishnan deleted the fix_479 branch August 31, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Module instantiation doesn't instantiate parameters
2 participants
@Raamakrishnan @mshr-h