[experimental-tmp2] lk2nd: dts: msm8994: include xiaomi-libra dts #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The msm8916 samsung.dts results in a lot of QCDT entries (records) because each qcom,msm-id is combined with each qcom,board-id. However, each board-id is actually only valid for one particular msm-id, so we can save quite some space by cleaning them up here. This is a bit of a hack but since this is a custom copy of dtbTool anyway it's not much of a problem. Also, reverting this (or using the standard dtbTool) would not result in a functional difference, just a larger build result.
Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
fekz115
changed the title
pevik
reviewed
May 26, 2023
| libra { | ||
| model = "Xiaomi Mi 4C"; | ||
| compatible = "xiaomi,libra"; | ||
|
|
There was a problem hiding this comment.
@fekz115 Here is whitespace (2 tabs), please remove it).
pevik
reviewed
May 26, 2023
| }; | ||
|
|
||
| &lk2nd { | ||
| libra { |
There was a problem hiding this comment.
I also wonder if there needs to be libra nod.
pevik
reviewed
May 26, 2023
| compatible = "xiaomi,libra"; | ||
|
|
||
| qcom,board-id = <12 0>; | ||
| qcom,pmic-id = <65545 65546 0 0>; |
There was a problem hiding this comment.
I'd move these to the top level / { nod.
stephan-gh
force-pushed
the
experimental-tmp2
branch
from
2600184
to
8ac99a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No panels for now, because they won't be used for a very long time