msm8939: huawei-kiwi: add lk1st #449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qhypstub [1] is an open-source "hyp" firmware replacement for MSM8916 that enables booting Linux and other operating systems in EL2 instead of EL1, making it possible to use virtualization features like KVM. To boot into aarch64 EL2 from aarch32 LK, the kernel must be started through the hypervisor with a HVC instead of a SMC. If the original "hyp" firmware is used (that does not allow booting in EL2), this HVC will just fail silently and we'll fall back to booting in EL1 via SMC. [1]: https://github.com/msm8916-mainline/qhypstub Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
The display doesn't light up otherwise.
This might need a better solution in the future, but for now lets place the necessary code directly into oem_panel. [Raymond: reimplement for huawei-kiwi]
TravMurav
reviewed
Nov 19, 2024
Comment on lines
+1080
to
+1085
| /* First try a hypervisor call to jump to EL2 if supported */ | ||
| scm_arg.hvc = true; | ||
| scm_call2(&scm_arg, NULL); | ||
|
|
||
| dprintf(INFO, "Falling back to SCM call\n"); | ||
| scm_arg.hvc = false; |
There was a problem hiding this comment.
This will crash on platforms that don't have hyp partition (or otherwise don't allow unknown hvc calls) so we didn't include el2 support until now, pending changes in qhypstub. Unfortunately neither me nor @stephan-gh had time to fix this yet...
There was a problem hiding this comment.
Yeah, I'd prefer not re-introducing this to the new branch. It's cleaner to change this in qhypstub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.