Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Basic authentication for online serve #14

Closed
ozgurOdun opened this issue Nov 6, 2017 · 4 comments
Closed

Basic authentication for online serve #14

ozgurOdun opened this issue Nov 6, 2017 · 4 comments
Labels
enhancement good first issue help wanted

Comments

@ozgurOdun
Copy link
Contributor

Hi Alex,
maybe a basic authentication procedure can be written to index and edit pages so the hacker-slides can be served to internet behind a web server. I will try to implement this in my spare time.
@msoedov
Copy link
Owner

msoedov commented Nov 6, 2017

That's sound like a reasonable feature. Any pull request will be welcomed :) I will see if I get time to work on this. Thank you for suggestion @ozgurOdun

msoedov added a commit that referenced this issue Nov 12, 2017
@msoedov
Merge pull request #16 from msoedov/pr14
c99e884 
#14 Optional basic auth
@msoedov
Copy link
Owner

msoedov commented Nov 12, 2017

@ozgurOdun just made a new release with basic auth middleware :)

@ozgurOdun
Copy link
Contributor Author

i will be testing today and let you know if any bugs or improvments. Thanks a lot :)

@msoedov
Copy link
Owner

msoedov commented Nov 14, 2017

We can work on bug fixes in a separate issue

@msoedov msoedov closed this as completed Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msoedov @ozgurOdun