Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with conda build #536

Merged
merged 5 commits into from
May 15, 2024
Merged

Fixing issues with conda build #536

merged 5 commits into from
May 15, 2024

Conversation

wangyinz
Copy link
Member

This branch will build all conda packages within the container. This should simplify the process and avoid some unknown issues with the versioning of the conda package the master branch currently have.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.57%. Comparing base (b56af55) to head (04b0577).

❗ Current head 04b0577 differs from pull request most recent head 83207f2. Consider uploading reports for the commit 83207f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   54.54%   54.57%   +0.03%     
==========================================
  Files         146      146              
  Lines       22358    22358              
  Branches     1336     1336              
==========================================
+ Hits        12195    12202       +7     
+ Misses       9823     9816       -7     
  Partials      340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyinz
Copy link
Member Author

Turns out the versioning didn't work because of the default behavior of the checkout step. It only checkout the current commit from the repo, which breaks the assumption of the versioning mechanism where we need to use the tags to identify the number. There are more discussions here: actions/checkout#217

@wangyinz wangyinz merged commit 90ecfab into master May 15, 2024
8 of 10 checks passed
@wangyinz wangyinz deleted the build-conda-fix branch May 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant