Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (cluster): [AKS v1.23] bump aks, kured versions and some minors #313

Merged
merged 11 commits into from
May 4, 2022

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented May 3, 2022

closes: #527157

WHY?

aks baseline should remain up to the latest aks version being released.

WHAT Changed?

  • bump aks cluster version up to 1.23
  • bump kured up to 1.9.2
  • bicep cluster-stamp
    • now all rbac roles are existing resources
    • remove reference function usage in favor of using the actual resource
  • add eastus2 location to acr and cluster-stamp being a friendly reminder for those who need to deploy to another region without issues.

HOW to Test?

you should be able to clone and follow the instructions to provision a new AKS cluster in version 1.23. Cluster looks healthy and you can execute the e2e validation without issues.

@ferantivero ferantivero changed the title feat (cluster): bump aks and kured versions feat (cluster): [AKS v1.23] bump aks and kured versions May 3, 2022
@ferantivero ferantivero changed the title feat (cluster): [AKS v1.23] bump aks and kured versions feat (cluster): [AKS v1.23] bump aks, kured versions and some other minors May 3, 2022
@ferantivero ferantivero marked this pull request as ready for review May 3, 2022 20:28
@ferantivero ferantivero requested a review from ckittel May 3, 2022 20:28
@ferantivero ferantivero changed the title feat (cluster): [AKS v1.23] bump aks, kured versions and some other minors feat (cluster): [AKS v1.23] bump aks, kured versions and some minors May 3, 2022
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just ONE change to make, with the comments. But after you make those changes, you can merge (see followup review). If you want, feel free to copy & paste the description of the role from docs OR you can try to describe it and how it's used in the RI -- either way is fine.

05-bootstrap-prep.md Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing I missed in my last review, and this is a blocker, unfortunately.

cluster-stamp.bicep Outdated Show resolved Hide resolved
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updated comment suggestions.

cluster-stamp.bicep Outdated Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
…ions

Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ckittel ckittel merged commit 16c56e3 into main May 4, 2022
@ckittel ckittel deleted the feature/527157_bump-v1.23 branch May 4, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants