-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (cluster): [AKS v1.23] bump aks, kured versions and some minors #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Just ONE change to make, with the comments. But after you make those changes, you can merge (see followup review). If you want, feel free to copy & paste the description of the role from docs OR you can try to describe it and how it's used in the RI -- either way is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing I missed in my last review, and this is a blocker, unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some updated comment suggestions.
…ions Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
closes: #527157
WHY?
aks baseline should remain up to the latest aks version being released.
WHAT Changed?
1.23
1.9.2
existing
resourcesreference
function usage in favor of using the actual resourceeastus2
location to acr and cluster-stamp being a friendly reminder for those who need to deploy to another region without issues.HOW to Test?
you should be able to clone and follow the instructions to provision a new AKS cluster in version
1.23
. Cluster looks healthy and you can execute the e2e validation without issues.