-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy custom policy as part of cluster deployment #345
Conversation
I decided for a Base64-coded specification of the Gatekeeper policy. The advantage is that the bicep is self-containing and we do not have a dependency of an external file we'd need to download from a GitHub repository. The disadvantage is that users cannot really read it. We could (a) leave it like that, (b) commit the policy into the repository (for reference only) and link in the explanation, (c) replace the encoding with the URL to the (readable) spec. Any thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great, @ulkeba. THANK YOU. Can you consider my suggestions below?
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Any thoughts on this? ☝️ |
I have no problem with it base64 encoded like you have it, without having to maintain a shadow copy. I was going to link to a base64 decoder in a comment, but didn't see any that MSFT owned publicly so I passed on that. If you wanted to give the user a hint, you can add a comment that says the body is base64 encoded, and if they wish to view it, to open it in a decoder. But I wouldn't worry about it. |
Looks like there are some merge conflicts @ulkeba -- if you can address those, and if you wanted to do any suggestions for the user to check out a decoder for the contents, then we'd be good to go with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you, @ulkeba!
PR contains: