Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #409

Merged
merged 22 commits into from
Apr 5, 2024
Merged

Updates #409

merged 22 commits into from
Apr 5, 2024

Conversation

skabou
Copy link
Contributor

@skabou skabou commented Apr 1, 2024

Image cleaner no longer in preview, now GA
AKS 1.29
Traefik 2.11
AzureLinux
bugfix: container image was missing curl
bugfix: kustomization patchesJson6902->patches

end-to-end
curl

skabou added 2 commits April 1, 2024 09:52
AzureLinux
AKS 1.29
Traefik 2.11
Other small bug fixes
@skabou skabou requested a review from ferantivero April 1, 2024 20:13
Copy link
Contributor

@ferantivero ferantivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done @skabou, please find some feedback below.

@@ -10,7 +10,7 @@ GitOps allows a team to author Kubernetes manifest files, persist them in their
- Cluster-wide configuration of Azure Monitor for Containers
- The workload's namespace named `a0008`

1. Install `kubectl` 1.27 or newer. (`kubectl` supports ±1 Kubernetes version.)
1. Install `kubectl` 1.28 or newer. (`kubectl` supports ±1 Kubernetes version.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we maintaining the client version n-1 for a reason? Any desire to move over 1.29 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the guidance I received from @ckittel on a previous PR.

Also, it appears to be official policy from Kubernetes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, while Im aware of how it gets supported, I was wondering why we are prescribing that. Just wanted to learn from this.

10-workload.md Show resolved Hide resolved
workload/aspnetapp-ingress-patch.yaml Outdated Show resolved Hide resolved
@skabou skabou requested a review from ferantivero April 4, 2024 15:44
Copy link
Contributor

@ferantivero ferantivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t @skabou, LGTM 🚢

@skabou skabou merged commit bbd38ca into mspnp:main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants