Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove USDC from withdraw tokens for Meta Harvester #313

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

D-Ig
Copy link
Member

@D-Ig D-Ig commented Jan 19, 2025

Issue

Link to Trello card

Description

https://github.com/dhedge/core-ui-kit/releases/tag/v0.4.8-legacy

Verifying

How to confirm changes, and explain how this was tested

Steps to verify

Expected results

Implementation details

Highlights of how the implementation fixes the issue or anything relevant about a new feature

Screenshots

Before

After

Related PRs

List related PRs against other branches:

Short identifier Source
back-end-related-pr link
some-other_pr link

Todos (if a PR is in work in progress state)

  • Tests
  • Documentation
  • Other things can be put here

@D-Ig D-Ig requested a review from dimlbc January 19, 2025 19:16
Copy link

github-actions bot commented Jan 19, 2025

Visit the preview URL for this PR (updated for commit 250e58f):

https://apps-lts--pr313-fix-meta-harvester-w-69cou18r.web.app

(expires Tue, 28 Jan 2025 18:45:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8debd0062e03d9ce09ac2458f17da263c61e4b71

Copy link

github-actions bot commented Jan 19, 2025

Visit the preview URL for this PR (updated for commit 250e58f):

https://dhedge-v1-withdraw--pr313-fix-meta-harvester-w-paf1hnxa.web.app

(expires Tue, 28 Jan 2025 18:46:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2157533cdfb02b956c33a37a482e9873c6f9154b

Copy link

github-actions bot commented Jan 19, 2025

Visit the preview URL for this PR (updated for commit 250e58f):

https://frontend-7e17f--pr313-fix-meta-harvester-w-q3ofj633.web.app

(expires Tue, 28 Jan 2025 18:47:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5e64a35c9bab805efe8cc6d7f4aabafe8180ef22

@D-Ig
Copy link
Member Author

D-Ig commented Jan 19, 2025

Visit the preview URL for this PR (updated for commit 17c5f3f):

https://frontend-7e17f--pr313-fix-meta-harvester-w-q3ofj633.web.app

(expires Mon, 27 Jan 2025 19:21:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5e64a35c9bab805efe8cc6d7f4aabafe8180ef22

@dimlbc I'm sorry, looks like the change I've made is not enough 🙂
could you please look into cooking a proper fix for that once you have time?

@dimlbc
Copy link
Member

dimlbc commented Jan 20, 2025

Visit the preview URL for this PR (updated for commit 17c5f3f):
https://frontend-7e17f--pr313-fix-meta-harvester-w-q3ofj633.web.app
(expires Mon, 27 Jan 2025 19:21:33 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 5e64a35c9bab805efe8cc6d7f4aabafe8180ef22

@dimlbc I'm sorry, looks like the change I've made is not enough 🙂 could you please look into cooking a proper fix for that once you have time?

Fixed

@dimlbc dimlbc merged commit 8db3ed3 into main Jan 21, 2025
4 checks passed
@dimlbc dimlbc deleted the fix/meta-harvester-withdraw-token branch January 21, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants