Skip to content

Commit

Permalink
Use windows-2019 in workflows and v142 (java-native-access#392)
Browse files Browse the repository at this point in the history
Motivation:

windows-2016 was removed so we need to use the next lowest which is 2019

Modifications:

- Use windows-2019
- Use v142

Result:

Builds on windows work again
  • Loading branch information
normanmaurer authored Mar 16, 2022
1 parent 853f460 commit b16a148
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
if-no-files-found: error

stage-snapshot-windows-x86_64:
runs-on: windows-2016
runs-on: windows-2019
name: stage-snapshot-windows-x86_64
env:
# Let's limit the amount of ram that is used to unpack rustup as we saw
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
**/hs_err*.log
build-pr-windows:
runs-on: windows-2016
runs-on: windows-2019
name: windows-x86_64 build
env:
# Let's limit the amount of ram that is used to unpack rustup as we saw
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ jobs:
run: bash ./.github/scripts/release_rollback.sh release.properties netty/netty-incubator-codec-quic main

stage-release-windows-x86_64:
runs-on: windows-2016
runs-on: windows-2019
name: stage-release-windows-x86_64
needs: prepare-release
env:
Expand Down
2 changes: 1 addition & 1 deletion codec-native-quic/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@
<customPackageDirectory>${templateDir}</customPackageDirectory>
<windowsBuildTool>msbuild</windowsBuildTool>
<windowsCustomProps>true</windowsCustomProps>
<windowsPlatformToolset>v140</windowsPlatformToolset>
<windowsPlatformToolset>v142</windowsPlatformToolset>
<libDirectory>${nativeLibOnlyDir}</libDirectory>
<configureArgs>
<configureArg>${extraConfigureArg}</configureArg>
Expand Down

0 comments on commit b16a148

Please sign in to comment.