Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uuid v7 instead of v4 #4052

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Use uuid v7 instead of v4 #4052

merged 2 commits into from
Jun 7, 2024

Conversation

clemens-msupply
Copy link
Contributor

Using uuid v7 improves write and improves read performance for sequential reads.

Fixes #4038

Using uuid v7 improves write and improves read performance for
sequential reads.
@github-actions github-actions bot added needs architecture/solution Needs wider dev input on general solution Priority: Nice to Have These changes are not critical for the workflow to work refactor labels Jun 6, 2024
Copy link
Contributor

@jmbrunskill jmbrunskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't most of our UUIDs generated from the frontend?
Does this exist for typescript? I assume it does?

@clemens-msupply
Copy link
Contributor Author

Aren't most of our UUIDs generated from the frontend? Does this exist for typescript? I assume it does?

ah yes you are right, would have to do it on the frontend

@clemens-msupply
Copy link
Contributor Author

Haha merged 3 days ago: uuidjs/uuid#681 but last release was 9 month ago...

@clemens-msupply
Copy link
Contributor Author

I had a look at the uuidv7 nodejs package https://www.npmjs.com/package/uuidv7. Also had a brief browse through the repo and it looks good to me...

Copy link

github-actions bot commented Jun 6, 2024

Bundle size difference

Comparing this PR to main

Old size New size Diff
8.88 MB 8.89 MB 6.18 KB (0.07%)

Copy link
Contributor

@jmbrunskill jmbrunskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@jmbrunskill jmbrunskill self-assigned this Jun 7, 2024
@clemens-msupply clemens-msupply merged commit fe3fd5c into develop Jun 7, 2024
4 checks passed
@clemens-msupply clemens-msupply deleted the 4038-uuid-v7 branch June 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs architecture/solution Needs wider dev input on general solution Priority: Nice to Have These changes are not critical for the workflow to work refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use UUIDv7 instead of v4
3 participants