Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deno support with denoify #11

Merged
merged 5 commits into from
Sep 23, 2023
Merged

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Aug 8, 2023

I've explicitly committed deno_dist directory following github.com/honojs/hono. By adding webhooks to deno 3rd party packages repository, this package could also be served from https://deno.land/x.

@scarf005 scarf005 marked this pull request as draft August 9, 2023 02:33
@scarf005 scarf005 marked this pull request as ready for review August 9, 2023 05:46
Copy link
Owner

@msutkowski msutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scarf005 I know roughly 0 things about denoify :). Does the denoify step need to be a part of a build step on publish, or does this just magically work as-is?

@scarf005
Copy link
Contributor Author

scarf005 commented Sep 23, 2023

it could be either

  • automated using workflow (i.e push to deno branch) to keep commit history clean, takes some work
  • or be ran and updated manually using npm run denoify command.

@msutkowski
Copy link
Owner

it could be either

  • automated using workflow (i.e push to deno branch) to keep commit history clean, takes some work
  • or be ran and updated manually using npm run denoify command.

Yea, looking through the example here - https://github.com/garronej/my_dummy_npm_and_deno_module, there is a little more that could be done re: tsconfig, setting "build": "pkgroll && denoify", etc etc. I'm assuming it makes sense to build + publish to deno.land as a part of the normal build step? I'd be happy to just throw the publish step in CI, but could use help with any of the deno parts =)

@msutkowski
Copy link
Owner

github.com/honojs/hono

Yea, we can just do what hono does and that should be fine - https://github.com/honojs/hono/blob/main/package.json#L27-L33. If you're on discord and would like to chat about this quickly, my username is the same (msutkowski). I'd like to get this + the other open PR in and update docs + cut a release today.

@msutkowski msutkowski merged commit 1bf6296 into msutkowski:main Sep 23, 2023
@scarf005 scarf005 deleted the denoify branch September 23, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno support
2 participants