-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: deno support with denoify #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scarf005 I know roughly 0 things about denoify :). Does the denoify step need to be a part of a build step on publish, or does this just magically work as-is?
it could be either
|
Yea, looking through the example here - https://github.com/garronej/my_dummy_npm_and_deno_module, there is a little more that could be done re: tsconfig, setting |
Yea, we can just do what hono does and that should be fine - https://github.com/honojs/hono/blob/main/package.json#L27-L33. If you're on discord and would like to chat about this quickly, my username is the same (msutkowski). I'd like to get this + the other open PR in and update docs + cut a release today. |
I've explicitly committed
deno_dist
directory following github.com/honojs/hono. By adding webhooks to deno 3rd party packages repository, this package could also be served from https://deno.land/x.