fix: handle inaccessible localStorage gracefully
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Node Internally in `jsdom` has a getter function defined for `localStorage` that can in some circumstances throw a runtime error that is not handled by the package The code has changed to use a function to qeury whether `localStorage` is available in the runtime context. If accessing `localStorage` global throws an error it returns an error otherwise `true` fixes mswjs#9
kettanaito
force-pushed
the
avoid-using-constant-for-localstorage-support
branch
from
9424964 to
2b7e183
Compare
kettanaito
changed the title
localStorage can throw error in …localStorage
kettanaito
changed the title
localStoragelocalStorage gracefully
kettanaito
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Thank you for addressing this, @weyert! Welcome to contributors! 🎉
Looking forward to working more with you.
|
🎉 This PR is included in version 0.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Node
Internally in
jsdomhas a getter function defined forlocalStoragethat can in some circumstances throw a runtime error that is not handled
by the package
The code has changed to use a function to qeury whether
localStorageisavailable in the runtime context. If accessing
localStorageglobal throwsan error it returns an error otherwise
truefixes #9