fix: give node export condition higher priority
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of mixed environments that look for both "node" and "browser" export conditions
kettanaito
reviewed
Apr 17, 2024
| "types": "./lib/node/RemoteHttpInterceptor.d.ts", | ||
| "node": { |
There was a problem hiding this comment.
Should we have "default" here too? I wonder when does it fall through "default" 🤔 If it's nether require not import? So, in the current state, it will find no "node.default", and fallback to the "/node.default" on the export path level?
There was a problem hiding this comment.
I think any tool that will apply an export condition like "node" will also apply "import" or "require". I would probably not pollute too much now until someone comes around the corner with an example where it's missing.
kettanaito
changed the title
node condition high prioritynode export condition higher priority
Released: v0.28.1 🎉This has been released in v0.28.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of mixed environments that look for both
"node" and "browser" export conditions