Skip to content

Commit

Permalink
test: check event.data before resolving
Browse files Browse the repository at this point in the history
  • Loading branch information
kettanaito committed Sep 19, 2024
1 parent 0c99078 commit a45981f
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion test/browser/ws-api/ws.clients.browser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ test('clears the list of clients when the page is reloaded', async ({
})
}

await enableMocking(page)
await enableMocking()

expect(await page.evaluate(() => window.link.clients.size)).toBe(0)

Expand Down
12 changes: 9 additions & 3 deletions test/browser/ws-api/ws.intercept.client.browser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ test('intercepts outgoing client text message', async ({
const worker = setupWorker(
service.addEventListener('connection', ({ client }) => {
client.addEventListener('message', (event) => {
resolve(event.data)
if (typeof event.data === 'string') {
resolve(event.data)
}
})
}),
)
Expand Down Expand Up @@ -91,7 +93,9 @@ test('intercepts outgoing client Blob message', async ({
const worker = setupWorker(
service.addEventListener('connection', ({ client }) => {
client.addEventListener('message', (event) => {
resolve(event.data.text())
if (event.data instanceof Blob) {
resolve(event.data.text())
}
})
}),
)
Expand Down Expand Up @@ -123,7 +127,9 @@ test('intercepts outgoing client ArrayBuffer message', async ({
const worker = setupWorker(
service.addEventListener('connection', ({ client }) => {
client.addEventListener('message', (event) => {
resolve(new TextDecoder().decode(event.data))
if (event.data instanceof Uint8Array) {
resolve(new TextDecoder().decode(event.data))
}
})
}),
)
Expand Down
10 changes: 7 additions & 3 deletions test/browser/ws-api/ws.intercept.server.browser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ test('intercepts incoming server text message', async ({
service.addEventListener('connection', ({ server }) => {
server.connect()
server.addEventListener('message', (event) => {
resolve(event.data)
if (typeof event.data === 'string') {
resolve(event.data)
}
})
}),
)
Expand Down Expand Up @@ -91,7 +93,9 @@ test('intercepts incoming server Blob message', async ({
service.addEventListener('connection', ({ server }) => {
server.connect()
server.addEventListener('message', (event) => {
resolve(event.data.text())
if (event.data instanceof Blob) {
resolve(event.data.text())
}
})
}),
)
Expand Down Expand Up @@ -137,7 +141,7 @@ test('intercepts outgoing server ArrayBuffer message', async ({
service.addEventListener('connection', ({ server }) => {
server.connect()
server.addEventListener('message', (event) => {
resolve(new TextDecoder().decode(event.data))
resolve(new TextDecoder().decode(event.data as Uint8Array))
})
}),
)
Expand Down

0 comments on commit a45981f

Please sign in to comment.