feat(fromTraffic): match query parameters #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to strictly match query parameters of a HAR file's request entry by matching the query string with the `queryString`-property of the entry.
kettanaito
reviewed
Jul 11, 2024
| @@ -56,7 +56,7 @@ | |||
| "@types/compression": "^1.7.1", | |||
| "@types/node": "18", | |||
| "compression": "^1.7.4", | |||
| "jsdom": "^22.1.0", | |||
There was a problem hiding this comment.
jsdom has a bug in URLSearchParams.prototype.delete. It ignores explicit value argument when dealing with multiple key/value pairs.
kettanaito
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
This is great! Thanks, @weyert 👏
I've added a few changes:
- Support for multi-value search parameters;
- Dropped jsdom in favor of happy-dom (fewer bugs);
- Added some test cases;
- Polished the implementation.
kettanaito
changed the title
kettanaito
reviewed
Jul 11, 2024
TILHappyDOM returns case-sensitive header names while neither the browser nor Node.js does that. Header names are lowercased per spec. |
Released: v0.2.0 🎉This has been released in v0.2.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to strictly match query parameters of a HAR file's request entry by matching the query string with the
queryString-property of the entry.fixes #45