fixup! sysconfig: make _sysconfigdata.py relocatable #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `sys.base_prefix` for sysconfig relocation Previously, we were using `sys.prefix` for relocation, which is not right as it may change for virtualenvs. `sys.base_prefix` is the right variable to use.
…lues for `LIBDIR`
naveen521kk
force-pushed
the
fix-sysconfig
branch
from
6f1c03b
to
7a6e8d2
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sys.base_prefixfor sysconfig relocationPreviously, we were using
sys.prefixfor relocation, which is not right as it may change for virtualenvs.sys.base_prefixis the right variable to use.