-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: debundle abseil #11758
grpc: debundle abseil #11758
Conversation
03bb704
to
70a7c7f
Compare
Converting to draft, as there are indeed linking errors to abseil-cpp:
and many more... |
70a7c7f
to
05f835a
Compare
These are indeed not exported from Maybe because we built abseil-cpp w/ C++17 and
The other linking errors are probably related... |
05f835a
to
640f26e
Compare
FWIW, abseil/abseil-cpp#696 may be a good read as it suggests possible workarounds. Note that while
|
That works, it just fails with fairly incomprehensible error messages when folks do not follow the rules. Consider an application developer using these packages, and trying to use it with code compiled with In other words, I am not saying that your current PR is wrong, it is a big improvement over the current state. I am saying it could provide less confusing errors when people do the "Wrong Thing":tm: |
Ok, let's make it somewhat *-proof then, hope this looks good now. |
dad8c4b
to
e577439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Resolves #11562