Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: unset VCPKG_ROOT #13368

Merged
merged 1 commit into from
Oct 2, 2022
Merged

CI: unset VCPKG_ROOT #13368

merged 1 commit into from
Oct 2, 2022

Conversation

MehdiChinoune
Copy link
Collaborator

Recently GHA started defining VCPKG_ROOT environment variable (actions/runner-images#6192).
So unset it to not let it autodetected and interfere with our build jobs.

Recently GHA started defining VCPKG_ROOT environment variable (actions/runner-images#6192).
So unset it to not let it autodetected and interfere with our build jobs.
@Biswa96
Copy link
Member

Biswa96 commented Oct 2, 2022

The build log of qt6-doc has many vcpkg related variables. Should not all of the be unset? 💭

@lazka
Copy link
Member

lazka commented Oct 2, 2022

Just curious, is there some package that failed because of this?

@MehdiChinoune
Copy link
Collaborator Author

Just curious, is there some package that failed because of this?

I think PkgConfig couldn't be found because of it (#13367).
vcpkg has its own CMAKE_TOOLCHAIN_FILE that defines many CMake variables and functions, which could interfere with our default CMake settings.

@lazka
Copy link
Member

lazka commented Oct 2, 2022

I see, thanks

@MehdiChinoune
Copy link
Collaborator Author

The build log of qt6-doc has many vcpkg related variables. Should not all of the be unset? 💭

The main reason is that vcpkg get autodetected in https://invent.kde.org/qt/qt/qtbase/-/blob/6.4.0/cmake/QtAutoDetect.cmake#L533 which rely on the environment variable VCPKG_ROOT to be defined in https://invent.kde.org/qt/qt/qtbase/-/blob/6.4.0/cmake/QtAutoDetect.cmake#L159

@MehdiChinoune MehdiChinoune merged commit 434d29a into msys2:master Oct 2, 2022
@MehdiChinoune MehdiChinoune deleted the unset-vcpkg branch October 2, 2022 09:25
lazka added a commit to msys2/msys2-autobuild that referenced this pull request Oct 2, 2022
@lazka
Copy link
Member

lazka commented Oct 2, 2022

Also done in autobuild: msys2/msys2-autobuild@c9dd9af

@MehdiChinoune
Copy link
Collaborator Author

MehdiChinoune commented Oct 10, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants