octave: build with LLVM compilers and update to 8.2.0 #16156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without patch
|
|
Pre-processed sources for the failing command: |
|
arpack, sundials and qrupdate are available on clang*64, could you rebase, adjust you PKGBUILD and enable clang64 and clangarm64 (assuming all deps are available). |
I did that. But I'm not sure if we should merge this. I kind of understand why distributing libraries might be useful for early adopters. Anyway, here it is... |
|
Please remove those julia changes! |
|
One minimal producer: program test
implicit none
complex :: z = cmplx(0., 1.)
print*, z**2
end programUCRT64 CLANG64 |
|
That doesn't look like it is related to Octave. |
Yes, It is not. It shows flang deficiency. |
Did you report that to the LLVM developers? |
|
@mmuetzel I can test CLANGARM64 to see if at least starts. Is this branch ready for trying a build? |
Thanks. The best we can expect is probably that it will crash as easy as the CLANG64 version during execution. |
I have investigated it a little, Flang works on Linux very well (beside not supporting some Fortran standards). It fails on MINGW at what they called lowering which is flang->MLIR->LLVM I think something only one from Flang could investigate. |
|
It's launching in CLANGARM64. I don't know why octave-gui is launching the cli version (I do have Qt). |
|
Thanks. 🎉 The naming of the executables might be a bit misleading. The How far does |
|
I don't know about the tests, but plotting is working |
|
|
Wow! That's further than I ever got on CLANG64. The test errors are probably mainly due to incompatibilities between |
|
@hmartinez82: Octave 8.2 is probably going to be released within the next week. |
|
Correct. I wonder if sundial or one of its deps are the reason why you are having issues with CLANG64 |
Be aware of frequent crashes in these environments.
Thanks. I'll do that, too.
Octave is currently crashing for the following commands on That comes down to calling the LAPACK subroutines |
|
Bringing the recent discussion from llvm/llvm-project#61976 back to here:
Even after rebuilding LAPACK (and Octave) with the patched flang, the above example still crashes. |
|
I have rebuilt lapack and then octave (using this branch) and it works for me in CLI mode at least: EDIT: |
Thanks for testing. It's crashing for me. Maybe it's time for a spring cleaning for me. I'll re-install MSYS2 and try again.
What do you mean by "fails"? Does it show an error? Or does it crash? Edit: In case it crashes: That might be for one of the tests for Edit 2: It looks like Edit 3: |
List more optional dependencies.
Sorry, I meant it segfaults but typed fails for some reason. With Details |
|
Thanks for testing again. Looking good. 🎉 That was with a rebuilt QRUPDATE. PS: I bumped the pkgrel of LAPACK and QRUPDATE in the repo. |
mmuetzel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires that the LAPACK package was built and installed (manually) previously for the CLANG64 environment.(Manually building LAPACK is no longer necessary.)I tried to add some explanatory comments for the used work-arounds.
Octave builds and starts for me with this. But it is crashing for some operations involving complex numbers. I only did some very limited exploratory testing though. So, there might be more errors/crashes/incorrect results/...