-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: fritzing #7376
New package: fritzing #7376
Conversation
I am not sure about your desired solution. Extrapolating from the |
Seems to be the best option since the prefix isn't known at build time.
Yeah, relative to the executable was kind of what I was thinking, too...
One was cherry-picked. Comment added. I'm planning to submit the other numbered patches as a pull request upstream, for mingw support. |
The patch switching to the unix behavior for looking for files on mingw, and adding |
Fritzing will just update to the latest master commit at launch, so it doesn't really matter other than for package build reproducibility.
This is what upstream uses in their packages, and reduces the .git directory from ~140MB to ~24MB.
My first attempt at packaging something.
https://fritzing.org
https://github.com/fritzing/fritzing-app
Major
outstandingsolved issue is that Fritzing cannot find its files out of the box. This can be worked around by launchingFritzing -f /mingw{32,64}/share/fritzing
. It passes path defines to the compiler, but I found that in order forqmake
to allowmake install
to work properly I had to useMSYS2_ARG_CONV_EXCL="PREFIX="
. That results in that define using a path starting with /mingw64. Not that the alternative would have been better, since that was an absolute path on the GHA builder... Also, the code that uses that is ifdef'd out onQT_OS_WIN
. Is there some common solution for mingw programs to know their prefix, so they can find their installed files?A couple of points of oddness about this package:
git
to turn thefritzing-parts
checkout from makepkg into a self-contained git repo with the proper origin url and branch name.