Skip to content

Commit

Permalink
Drop BUILD_TYPES_WIP
Browse files Browse the repository at this point in the history
This wasn't complete as it would only ignore broken builds
for direct deps and not indirect ones, but kinda worked in ignoring
some arm64 errors.

But it also causes problems if an error is ignored and the other arches
get uploaded. Then it's hard to roll back the update because lots of
packages with the new version are already in the repo.

With the new autobuild controller we can also restart flaky builds instead
of ignoring them and waiting for jeremy to fix them later.

Let's try removing that special case.
  • Loading branch information
lazka committed Sep 20, 2022
1 parent 253f8b8 commit b40229d
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions autobuild.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,6 @@ class Config:
}
"""XXX: In case of cycles we mark these deps as optional"""

BUILD_TYPES_WIP: List[BuildType] = ["clangarm64"]
"""XXX: These build types don't block other things, even if they fail/don't get built"""


_PathLike = Union[os.PathLike, AnyStr]

Expand Down Expand Up @@ -923,8 +920,7 @@ def pkg_is_manual(build_type: BuildType, pkg: Package) -> bool:

for dep_type, deps in pkg.get_rdepends(build_type).items():
for dep in deps:
if dep["name"] in Config.IGNORE_RDEP_PACKAGES or \
(build_type != dep_type and dep_type in Config.BUILD_TYPES_WIP):
if dep["name"] in Config.IGNORE_RDEP_PACKAGES:
continue
dep_status = dep.get_status(dep_type)
dep_new = dep.is_new(dep_type)
Expand All @@ -946,8 +942,7 @@ def pkg_is_manual(build_type: BuildType, pkg: Package) -> bool:
blocked.append(build_type)
# if the package isn't in the repo better not block on it
elif not pkg.is_new(build_type):
if build_type not in Config.BUILD_TYPES_WIP:
unfinished.append(build_type)
unfinished.append(build_type)
else:
finished.append(build_type)

Expand Down

0 comments on commit b40229d

Please sign in to comment.