Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallout from pathconf changes #190

Closed
lazka opened this issue Jan 26, 2024 · 0 comments · Fixed by #196
Closed

Fallout from pathconf changes #190

lazka opened this issue Jan 26, 2024 · 0 comments · Fixed by #196
Labels
pathconv

Comments

@lazka
Copy link
Member

lazka commented Jan 26, 2024 •
edited
Loading

CPython currently doesn't build because of this. Code in CPython: https://github.com/msys2-contrib/cpython-mingw/blob/ebc5f3fc250c0ae937663e43bc11ef5ab7830888/Makefile.pre.in#L1294-L1302

Before:

python3 -c "import sys; print(sys.argv)" -DPREFIX='"/ucrt64"'
['-c', '-DPREFIX="C:/msys64/ucrt64"']

After:

python3 -c "import sys; print(sys.argv)" -DPREFIX='"/ucrt64"'
['-c', '-DPREFIX="/ucrt64"']
@lazka lazka mentioned this issue Jan 26, 2024
Merged
@lazka lazka added the pathconv label Jan 27, 2024
@naveen521kk naveen521kk mentioned this issue Feb 8, 2024
Closed
lazka added a commit to lazka/Cygwin that referenced this issue Feb 10, 2024
@lazka
pathconv: don't skip arguments with double quote
3e658ce 
It is used to pass strings/paths to the preprocessor and breaks
for example the CPython build. For example -DPREFIX='"/ucrt64"'.

Fixes msys2#190
@lazka lazka mentioned this issue Feb 10, 2024
Merged
lazka added a commit that referenced this issue Feb 11, 2024
@lazka
pathconv: don't skip arguments with double quote
65672ed 
It is used to pass strings/paths to the preprocessor and breaks
for example the CPython build. For example -DPREFIX='"/ucrt64"'.

Fixes #190
@jeremyd2019 jeremyd2019 mentioned this issue Feb 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pathconv
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pathconv: don't skip arguments with double quote lazka/Cygwin
1 participant
@lazka