Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failure after update to msys2-w32api #214

Closed
jeremyd2019 opened this issue May 17, 2024 · 5 comments · Fixed by #215
Closed

build failure after update to msys2-w32api #214

jeremyd2019 opened this issue May 17, 2024 · 5 comments · Fixed by #215

Comments

@jeremyd2019
Copy link
Member

After msys2-w32api was updated to 11.0.1.r750.g05598db99-1 I am seeing a build failure in msys2-runtime:

  /C/_/msys2-runtime/src/msys2-runtime/winsup/cygwin/exceptions.cc: In member function 'int _cygtls::call_signal_handler()':
  /C/_/msys2-runtime/src/msys2-runtime/winsup/cygwin/exceptions.cc:1736:33: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]
   1736 |               RtlCaptureContext ((PCONTEXT) &context.uc_mcontext);
        |               ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@lazka
Copy link
Member

lazka commented May 17, 2024 •
edited
Loading

Yeah, thanks, I saw that too locally, I guess we should add -Wno-error=maybe-uninitialized

msys2-runtime/winsup/cygwin/exceptions.cc

Line 1736 in abcb3c6

RtlCaptureContext ((PCONTEXT) &context.uc_mcontext);

edit: mingw-w64/mingw-w64@e98e24b

lazka added a commit to lazka/Cygwin that referenced this issue May 17, 2024
@lazka
CI: set -Wno-error=maybe-uninitialized
fbe70ac 
After the update of msys2-w32api from v11.0.1 to current master (and soon to be v12)
we get: winsup/cygwin/exceptions.cc:1736:33: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]

Ignore it like the rest.

Fixes msys2#214
@lazka lazka mentioned this issue May 17, 2024
Merged
@lazka
Copy link
Member

lazka commented May 17, 2024

I've created #215

@jeremyd2019
Copy link
Member Author

jeremyd2019 commented May 17, 2024 •
edited
Loading

I really don't understand what it is that it is trying to warn about there. It doesn't look like the CONTEXT struct changed, but RtlCaptureContext got a new __attribute__((__returns_twice__))

lazka added a commit that referenced this issue May 28, 2024
@lazka
CI: set -Wno-error=maybe-uninitialized
3f5eb36 
After the update of msys2-w32api from v11.0.1 to current master (and soon to be v12)
we get: winsup/cygwin/exceptions.cc:1736:33: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]

Ignore it like the rest.

Fixes #214
@jeremyd2019
Copy link
Member Author

I was just attempting to build upstream cygwin on cygwin using latest non-test versions of cygwin packages, and got this same warning-as-error. So maybe upstream will do something about this one.

@jeremyd2019
Copy link
Member Author

7e3c833

lazka added a commit that referenced this issue Aug 25, 2024
@lazka
CI: set -Wno-error=maybe-uninitialized
773b5d9 
After the update of msys2-w32api from v11.0.1 to current master (and soon to be v12)
we get: winsup/cygwin/exceptions.cc:1736:33: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]

Ignore it like the rest.

Fixes #214
dscho pushed a commit that referenced this issue Aug 27, 2024
@lazka @dscho
CI: set -Wno-error=maybe-uninitialized
997f6f3 
After the update of msys2-w32api from v11.0.1 to current master (and soon to be v12)
we get: winsup/cygwin/exceptions.cc:1736:33: error: '<anonymous>' may be used uninitialized [-Werror=maybe-uninitialized]

Ignore it like the rest.

Fixes #214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: set -Wno-error=maybe-uninitialized lazka/Cygwin
2 participants
@lazka @jeremyd2019