Fix out-of-bound access in path conversion #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope this also fixes the "bad address" issue which is blocking microsoft/vcpkg#34274. |
…nvironment variables to Windows form for native Win32 applications. Don't memchr behind end, it+1
…nvironment variables to Windows form for native Win32 applications. Don't memchr behind end, it2
|
I amended the commit messages so that the next rebase will squash the changes into the faulty commit. But that's all I did, the diff of the force-push is empty. |
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Nov 22, 2023
This commit corresponds to msys2/msys2-runtime#179 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Nov 23, 2023
This synchronizes Git for Windows' fork of the MSYS2 runtime with MSYS2's version, most notably addressing two bugs that could cause "Bad address" errors: msys2/msys2-runtime#179 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Nov 23, 2023
Most notably, this integrates the fixes from msys2/msys2-runtime#179. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/msys2-tests
that referenced
this pull request
Feb 27, 2024
In msys2/msys2-runtime#179 ("Fix out-of-bound access in path conversion"), _two_ instances were fixed where `it` was used when `it2` should have been used instead. In 3a20d2f (Sync path_conv.pp with msys2-runtime, 2023-12-22), only one of those fixes was applied. Let's apply the other one, too. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
lazka
added a commit
to msys2/msys2-tests
that referenced
this pull request
Feb 28, 2024
path_conv: backport forgotten part of msys2/msys2-runtime#179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix msys2/MSYS2-packages#2282.