-
Notifications
You must be signed in to change notification settings - Fork 316
Fix test suite issues with iso8859-1 parameters #156
Conversation
…utf-8." This reverts commit 2482bc9.
This reverts commit a0530b4.
git commit -m with some iso8859-1 encoded stuff is doomed to fail in MinGW, because Windows don't let you pass encoded bytes to a process (CreateProcessW always takes a UTF-16LE encoded string). Fix t4041, t7102 and update an older fix in t4205. Thanks-to: Karsten Blees <blees@dcon.de>
Please note that force-pushing to the branch updates the pull request, so there was no need to open another pull request for the same issue. I will review after merging the tag-contains branch. |
I tried to work along these lines. But I closed the PR first, indicating that this is not the right one. |
@kasal once you close a pull request, the commit list is not updated until you reopen. Typically it is enough to comment: "Hold off!". We're usually very good at reading what you write in those comments ;-) |
:-) thanks |
MSysGit - the development behind Git for Windows » git #182 SUCCESS |
Fix test suite issues with iso8859-1 parameters
Passed the test suite after a couple of hours! Thank you so much! You really helped this project! |
Fix test suite issues with iso8859-1 parameters
I fixed the two failing test scripts following Karsten's hint from here:
2482bc9#commitcomment-5946968
I had this as one commit originally (kasal:test-fix) but changed that to contain reverts.
I found a similar fix in t4205, so I updated it and added a comment.
Out of curiosity:
What about 1.9.1? Are you going to rebase the msysgit-specific patches? Should the reverted ones get dropped?