Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Fix test suite issues with iso8859-1 parameters #156

Merged
merged 3 commits into from
Apr 9, 2014

Conversation

kasal
Copy link
Member

@kasal kasal commented Apr 9, 2014

I fixed the two failing test scripts following Karsten's hint from here:
2482bc9#commitcomment-5946968

I had this as one commit originally (kasal:test-fix) but changed that to contain reverts.

I found a similar fix in t4205, so I updated it and added a comment.

Out of curiosity:
What about 1.9.1? Are you going to rebase the msysgit-specific patches? Should the reverted ones get dropped?

git commit -m with some iso8859-1 encoded stuff is doomed to fail in MinGW,
because Windows don't let you pass encoded bytes to a process (CreateProcessW
always takes a UTF-16LE encoded string).

Fix t4041, t7102 and update an older fix in t4205.

Thanks-to: Karsten Blees <blees@dcon.de>
@dscho
Copy link
Member

dscho commented Apr 9, 2014

Please note that force-pushing to the branch updates the pull request, so there was no need to open another pull request for the same issue.

I will review after merging the tag-contains branch.

@kasal
Copy link
Member Author

kasal commented Apr 9, 2014

I tried to work along these lines. But I closed the PR first, indicating that this is not the right one.
I would reopen later, if the commit list changed, but it didn't.
This was probably my fault, as I used delete&create instead of --force, and I pushed the right version on second attempt. I'll do better next time.

@dscho
Copy link
Member

dscho commented Apr 9, 2014

@kasal once you close a pull request, the commit list is not updated until you reopen. Typically it is enough to comment: "Hold off!". We're usually very good at reading what you write in those comments ;-)

@kasal
Copy link
Member Author

kasal commented Apr 9, 2014

:-) thanks

@buildhive
Copy link

MSysGit - the development behind Git for Windows » git #182 SUCCESS
This pull request looks good
(what's this?)

dscho added a commit that referenced this pull request Apr 9, 2014
Fix test suite issues with iso8859-1 parameters
@dscho dscho merged commit 5120b9a into msysgit:master Apr 9, 2014
@dscho
Copy link
Member

dscho commented Apr 9, 2014

Passed the test suite after a couple of hours!

Thank you so much! You really helped this project!

@kasal kasal deleted the test-fix-rev branch April 10, 2014 08:31
dscho added a commit that referenced this pull request Apr 10, 2014
Fix test suite issues with iso8859-1 parameters
dscho added a commit that referenced this pull request Apr 11, 2014
This reverts commit e42bb07, reversing
changes made to 648a344.

These changes will be obsoleted by the 'win-tests-rebase' branch.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this pull request May 25, 2015
dscho added a commit to dscho/git that referenced this pull request Jun 10, 2015
dscho added a commit to dscho/git that referenced this pull request Jun 17, 2015
kblees pushed a commit to kblees/git that referenced this pull request Jun 30, 2015
dscho added a commit to dscho/git that referenced this pull request Jul 18, 2015
dscho added a commit to dscho/git that referenced this pull request Jul 28, 2015
dscho added a commit to dscho/git that referenced this pull request Aug 30, 2015
dscho added a commit to dscho/git that referenced this pull request Sep 12, 2015
dscho added a commit to dscho/git that referenced this pull request Sep 18, 2015
dscho added a commit to dscho/git that referenced this pull request Sep 29, 2015
dscho added a commit to dscho/git that referenced this pull request Oct 7, 2015
dscho added a commit to dscho/git that referenced this pull request Oct 18, 2015
dscho added a commit to dscho/git that referenced this pull request Nov 24, 2016
dscho added a commit to dscho/git that referenced this pull request Nov 29, 2016
dscho added a commit to dscho/git that referenced this pull request Dec 20, 2016
PhilipOakley referenced this pull request in PhilipOakley/git Jan 26, 2017
PhilipOakley referenced this pull request in PhilipOakley/git Jan 26, 2017
dscho added a commit to dscho/git that referenced this pull request Feb 1, 2017
dscho added a commit to dscho/git that referenced this pull request Feb 4, 2017
dscho added a commit to dscho/git that referenced this pull request Feb 4, 2017
dscho added a commit to dscho/git that referenced this pull request Feb 21, 2017
dscho added a commit to dscho/git that referenced this pull request Feb 25, 2017
dscho added a commit to dscho/git that referenced this pull request Mar 20, 2017
dscho added a commit to dscho/git that referenced this pull request Apr 17, 2017
dscho added a commit to dscho/git that referenced this pull request Apr 17, 2017
dscho added a commit to dscho/git that referenced this pull request May 17, 2017
dscho added a commit to dscho/git that referenced this pull request May 17, 2017
dscho added a commit to dscho/git that referenced this pull request May 17, 2017
dscho added a commit to dscho/git that referenced this pull request Jun 19, 2017
dscho added a commit to dscho/git that referenced this pull request Jun 26, 2017
dscho added a commit to dscho/git that referenced this pull request Jul 13, 2017
dscho added a commit to dscho/git that referenced this pull request Jul 25, 2017
dscho added a commit to dscho/git that referenced this pull request Aug 10, 2017
dscho added a commit to dscho/git that referenced this pull request Aug 10, 2017
dscho added a commit to dscho/git that referenced this pull request Aug 26, 2017
dscho added a commit to dscho/git that referenced this pull request Sep 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants