This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
poll: honor the timeout on Win32 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For additional background, see http://lists.gnu.org/archive/html/bug-gnulib/2014-09/msg00045.html. Please note the updated patch later in the thread (http://lists.gnu.org/archive/html/bug-gnulib/2014-09/msg00070.html) which is what was cherry-picked here. |
|
MSysGit - the development behind Git for Windows » git #277 SUCCESS |
Ensure that when passing a pipe, the gnulib poll replacement will not return 0 before the timeout has passed. Not obeying the timeout (and merely returning 0) causes pathological behavior when preparing a packfile for a repository and taking a long time to do so. If poll were to return 0 immediately, this would cause keep-alives to get sent as quickly as possible until the packfile was created. Such deviance from the standard would cause megabytes (or more) of keep-alive packets to be sent. GetTickCount is used as it is efficient, stable and monotonically increasing. (Neither GetSystemTime nor QueryPerformanceCounter have all three of these properties.)
dscho
added a commit
that referenced
this pull request
Mar 18, 2015
poll: honor the timeout on Win32
|
Thank you so much! Do you want a new |
|
Nope! I'm in no hurry, I'm happy to use a locally patched build. Thanks! :) |
|
Okay, then I'll forward port this patch to the upcoming MSys2-based Git for Windows. |
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 18, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
MSysGit - the development behind Git for Windows » git #278 SUCCESS |
|
Good catch! |
|
MSysGit - the development behind Git for Windows » git #279 SUCCESS |
|
@t-b yes, it is safe to pick. Thank you! |
|
@dscho Thanks. I"ve picked it. |
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 20, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Apr 1, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
referenced
this pull request
in git-for-windows/git
Apr 23, 2015
This was originally 'pull request #330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Apr 29, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
referenced
this pull request
in git-for-windows/git
May 1, 2015
This was originally 'pull request #330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
May 14, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Jun 10, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Jun 17, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
referenced
this pull request
in git-for-windows/git
Jun 25, 2015
This was originally 'pull request #330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Jul 18, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Jul 28, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 30, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Sep 12, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Sep 18, 2015
This was originally 'pull request msysgit#330 from ethomson/poll_inftim' in msysgit/git. poll: honor the timeout on Win32 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when passing a pipe, the gnulib poll replacement will not
return 0 before the timeout has passed.
Not obeying the timeout (and merely returning 0) causes pathological
behavior when preparing a packfile for a repository and taking a
long time to do so. If poll were to return 0 immediately, this would
cause keep-alives to get sent as quickly as possible until the packfile
was created. Such deviance from the standard would cause megabytes (or
more) of keep-alive packets to be sent.
GetTickCountis used as it is efficient, stable and monotonicallyincreasing. (Neither
GetSystemTimenorQueryPerformanceCounterhaveall three of these properties.)