Changed belongs to belong in error message, add integration tests(#108)

Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
mszostok · Feb 12, 2022 · 0e709b4 · 0e709b4
1 parent e933870
commit 0e709b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/check/valid_owner.go b/internal/check/valid_owner.go
@@ -195,7 +195,7 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr
 	team := parts[1]
 
 	if org != v.orgName {
-		return newValidateError("Team %q does not belongs to %q organization.", team, v.orgName)
+		return newValidateError("Team %q does not belong to %q organization.", name, v.orgName)
 	}
 
 	teamExists := func() bool {
@@ -208,7 +208,7 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr
 	}
 
 	if !teamExists() {
-		return newValidateError("Team %q does not exist in organization %q.", team, org)
+		return newValidateError("Team %q does not exist in organization %q.", name, org)
 	}
 
 	// repo contains the permissions for the team slug given

diff --git a/tests/integration/testdata/TestCheckFailures/owners.golden.txt b/tests/integration/testdata/TestCheckFailures/owners.golden.txt
@@ -38,7 +38,8 @@
     [err] line 15: Team "vikings" cannot review PRs on "codeowners-samples" as neither it nor any parent team has write permissions.
     [err] line 15: Team "warriors" does not have permissions associated with the repository "codeowners-samples".
     [err] line 15: Team "wolf-pack" does not have permissions associated with the repository "codeowners-samples".
-    [err] line 17: Team "not-existing-team" does not exist in organization "gh-codeowners".
+    [err] line 17: Team "@gh-codeowners/not-existing-team" does not exist in organization "gh-codeowners".
+    [err] line 17: Team "@wrong-org/a-team" does not belong to "gh-codeowners" organization.
     [war] line 23: Missing owner, at least one owner is required
 
 1 check(s) executed, 1 failure(s)