Add integration test coverage

mszostok · Feb 13, 2022 · 310984f · 310984f
1 parent 6f125c3
commit 310984f
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 4 deletions.
diff --git a/tests/integration/helpers_test.go b/tests/integration/helpers_test.go
@@ -1,3 +1,4 @@
+//go:build integration
 // +build integration
 
 package integration
@@ -105,3 +106,10 @@ func (s *Executor) Binary(binaryPath string) *Executor {
 	s.binaryPath = binaryPath
 	return s
 }
+
+func stringDefault(in, def string) string {
+	if in == "" {
+		return def
+	}
+	return in
+}
diff --git a/tests/integration/integration_test.go b/tests/integration/integration_test.go
@@ -15,8 +15,9 @@ import (
 )
 
 const (
-	binaryPathEnvName     = "BINARY_PATH"
-	codeownersSamplesRepo = "https://github.com/gh-codeowners/codeowners-samples.git"
+	binaryPathEnvName                       = "BINARY_PATH"
+	codeownersSamplesRepo                   = "https://github.com/gh-codeowners/codeowners-samples.git"
+	caseInsensitiveOrgCodeownersSamplesRepo = "https://github.com/GitHubCODEOWNERS/codeowners-samples.git"
 )
 
 // TestCheckHappyPath tests that codeowners-validator reports no issues for valid CODEOWNERS file.
@@ -31,6 +32,7 @@ func TestCheckSuccess(t *testing.T) {
 	type Envs map[string]string
 	tests := []struct {
 		name   string
+		repo   string
 		envs   Envs
 		skipOS string
 	}{
@@ -48,6 +50,15 @@ func TestCheckSuccess(t *testing.T) {
 				"GITHUB_ACCESS_TOKEN":      os.Getenv("GITHUB_TOKEN"),
 			},
 		},
+		{
+			name: "owners",
+			envs: Envs{
+				"CHECKS":                   "owners",
+				"OWNER_CHECKER_REPOSITORY": "GitHubCODEOWNERS/codeowners-samples",
+				"GITHUB_ACCESS_TOKEN":      os.Getenv("GITHUB_TOKEN"),
+			},
+			repo: caseInsensitiveOrgCodeownersSamplesRepo,
+		},
 		{
 			name: "duppatterns",
 			envs: Envs{
@@ -71,7 +82,7 @@ func TestCheckSuccess(t *testing.T) {
 			}
 
 			// given
-			repoDir, cleanup := CloneRepo(t, codeownersSamplesRepo, "happy-path")
+			repoDir, cleanup := CloneRepo(t, stringDefault(tc.repo, codeownersSamplesRepo), "happy-path")
 			defer cleanup()
 
 			binaryPath := os.Getenv(binaryPathEnvName)
@@ -93,7 +104,7 @@ func TestCheckSuccess(t *testing.T) {
 			normalizedOutput := normalizeTimeDurations(result.Stdout)
 
 			g := goldie.New(t, goldie.WithNameSuffix(".golden.txt"))
-			g.Assert(t, t.Name(), []byte(normalizedOutput))
+			g.Assert(t, tc.name, []byte(normalizedOutput))
 		})
 	}
 }

diff --git a/tests/integration/testdata/duppatterns.golden.txt b/tests/integration/testdata/duppatterns.golden.txt
@@ -0,0 +1,4 @@
+==> Executing Duplicated Pattern Checker (<duration>)
+    Check OK
+
+1 check(s) executed, no failure(s)
diff --git a/tests/integration/testdata/files.golden.txt b/tests/integration/testdata/files.golden.txt
@@ -0,0 +1,4 @@
+==> Executing File Exist Checker (<duration>)
+    Check OK
+
+1 check(s) executed, no failure(s)
diff --git a/tests/integration/testdata/notowned.golden.txt b/tests/integration/testdata/notowned.golden.txt
@@ -0,0 +1,4 @@
+==> Executing [Experimental] Not Owned File Checker (<duration>)
+    Check OK
+
+1 check(s) executed, no failure(s)
diff --git a/tests/integration/testdata/owners.golden.txt b/tests/integration/testdata/owners.golden.txt
@@ -0,0 +1,4 @@
+==> Executing Valid Owner Checker (<duration>)
+    Check OK
+
+1 check(s) executed, no failure(s)