Enforce only one CODEOWNERS file #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
reviewed
Feb 9, 2022
pkg/codeowners/owners.go
Outdated
| if fileReader != nil { | ||
| return nil, fmt.Errorf("Multiple CODEOWNERS files found in root, docs/, or .github/ directory of the repository %s", dir) | ||
| } | ||
| fileReader, err = fs.Open(f) |
There was a problem hiding this comment.
missing error handling, errors related to opening a file will be silenced
pkg/codeowners/owners.go
Outdated
|
|
||
| return fs.Open(f) | ||
| if fileReader != nil { | ||
| return nil, fmt.Errorf("Multiple CODEOWNERS files found in root, docs/, or .github/ directory of the repository %s", dir) |
There was a problem hiding this comment.
It would be better to tell where we spot those duplications exactly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
codeowners-validator currently allows multiple codeowners files, grabbing the first one it finds. There is no valid use for codeowners files in multiple places.
This PR enforces only one codeowners file
Related issue(s)
Resolves #97