-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not-owned-checker: Add git-ls-tree implementation with subdirectory support #141
Conversation
@mszostok on second thought I'll need to hold off on this until I fix one thing. |
Hi! Thanks for the PR. The feature is reasonable 👍 However, I see that CI fails. I check that locally, and I was also getting the same issues. It turns out that the
Why the Tested on:
|
Ah, I might've missed that |
Fixed an issue with Putting back in review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I like the idea that you implemented. I only added e2e tests to ensure no regression in the future.
Great, thanks @mszostok! Pls me know if you're able to handle the release with this added. |
Hi @jeremycohen, yes I will create a new release, it will be today or tomorrow as I want to merge one more PR 👍 |
Hi @jeremycohen the new release is available. However, I spot an issue: This is due to the yesterday git release, see more in: Let me know if it's also a problem on your side. There are some workarounds: actions/checkout#760 Unfortunately, I was not able to apply them with success. I will wait a bit more, as maybe there will be some official statement on how to approach that problem with GitHub Actions. |
Hey @mszostok, thanks for the release! Appreciate it. I tried upgrading to git 2.35.2 locally and wasn't able to repro. Our CI machines haven't been upgraded to 2.35.2 yet, but will keep you posted if we see this issue. We can probably use that workaround in our checks if needed and |
Description
Changes proposed in this pull request:
NOT_OWNED_CHECKER_SUBDIRECTORIES
. If a file does not exist within these subdirectories, thenot-owned-checker
will not return that file when seeing if it doesn't have an ownergit ls-files
after creating the artificial.gitignore
we can usegit ls-tree
which returns the same output with the set arguments. The subdirectories specified are added as additional arguments for filtering